From a4f838919020b587bb8dd4493e8881bb113d3be7 Mon Sep 17 00:00:00 2001 From: Benoit Daloze Date: Tue, 15 Jul 2025 22:28:17 +0200 Subject: [PATCH] Remove windows-2019 support * See https://github.com/actions/runner-images/issues/12045 --- .github/workflows/test.yml | 9 +-------- README.md | 4 ++-- common.js | 1 - dist/index.js | 1 - 4 files changed, 3 insertions(+), 12 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index ad4ddce..b07c794 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -17,7 +17,7 @@ jobs: strategy: fail-fast: false matrix: - os: [ ubuntu-22.04, ubuntu-24.04, ubuntu-22.04-arm, ubuntu-24.04-arm, macos-13, macos-14, macos-15, windows-2019, windows-2022, windows-2025, windows-11-arm ] + os: [ ubuntu-22.04, ubuntu-24.04, ubuntu-22.04-arm, ubuntu-24.04-arm, macos-13, macos-14, macos-15, windows-2022, windows-2025, windows-11-arm ] ruby: [ '1.9', '2.0', '2.1', '2.2', '2.3', '2.4', '2.5', '2.6', '2.7', '3.0', '3.1', '3.2', '3.3', '3.4', ruby-head, jruby, jruby-head, @@ -25,8 +25,6 @@ jobs: truffleruby+graalvm, truffleruby+graalvm-head ] include: - - { os: windows-2019, ruby: mingw } - - { os: windows-2019, ruby: mswin } - { os: windows-2022, ruby: mingw } - { os: windows-2022, ruby: mswin } - { os: windows-2022, ruby: ucrt } @@ -81,24 +79,19 @@ jobs: - { os: windows-11-arm, ruby: jruby } - { os: windows-11-arm, ruby: jruby-head } # RubyInstaller has no 64-bit builds of 1.9 on Windows - - { os: windows-2019, ruby: '1.9' } - { os: windows-2022, ruby: '1.9' } - { os: windows-2025, ruby: '1.9' } - { os: windows-11-arm, ruby: '1.9' } # TruffleRuby does not support Windows - - { os: windows-2019, ruby: truffleruby } - { os: windows-2022, ruby: truffleruby } - { os: windows-2025, ruby: truffleruby } - { os: windows-11-arm, ruby: truffleruby } - - { os: windows-2019, ruby: truffleruby-head } - { os: windows-2022, ruby: truffleruby-head } - { os: windows-2025, ruby: truffleruby-head } - { os: windows-11-arm, ruby: truffleruby-head } - - { os: windows-2019, ruby: truffleruby+graalvm } - { os: windows-2022, ruby: truffleruby+graalvm } - { os: windows-2025, ruby: truffleruby+graalvm } - { os: windows-11-arm, ruby: truffleruby+graalvm } - - { os: windows-2019, ruby: truffleruby+graalvm-head } - { os: windows-2022, ruby: truffleruby+graalvm-head } - { os: windows-2025, ruby: truffleruby+graalvm-head } - { os: windows-11-arm, ruby: truffleruby+graalvm-head } diff --git a/README.md b/README.md index 1f5b120..9a0d2c6 100644 --- a/README.md +++ b/README.md @@ -51,7 +51,7 @@ The action works on these [GitHub-hosted runners](https://docs.github.com/en/act | ---------------- | --------- | | Ubuntu | `ubuntu-22.04`, `ubuntu-24.04`, `ubuntu-22.04-arm`, `ubuntu-24.04-arm` | | macOS | `macos-13` and newer versions | -| Windows | `windows-2019`, `windows-2022`, `windows-2025`, `windows-11-arm` | +| Windows | `windows-2022`, `windows-2025`, `windows-11-arm` | Not all combinations of runner images and versions are supported. The list of available Ruby versions can be seen in [ruby-builder-versions.json](ruby-builder-versions.json) for Ubuntu and macOS @@ -243,7 +243,7 @@ It is recommended to first get your build working on Ubuntu and macOS before try * For Ruby < 2.4, the DevKit MSYS tools are installed and prepended to the `Path`. * Use JRuby 9.2.20+ on Windows (older versions have [bugs](https://github.com/ruby/setup-ruby/issues/18#issuecomment-889072695)). * JRuby on Windows has multiple issues ([jruby/jruby#7106](https://github.com/jruby/jruby/issues/7106), [jruby/jruby#7182](https://github.com/jruby/jruby/issues/7182)). -* When compiling extension code, note that the packages required to build Ruby are included when using Windows 2022, but that Windows 2019 does not include all of them, and may require installing package(s). This can be done with [setup-ruby-pkgs](https://github.com/ruby/setup-ruby-pkgs) or via MSYS2's pacman. These packages may be required when installing or updating Ruby std-lib extension gems. +* When compiling extension code, note that the packages required to build Ruby are included when using Windows 2022. Additional packages can be installed with [setup-ruby-pkgs](https://github.com/ruby/setup-ruby-pkgs) or via MSYS2's `pacman`. These packages may be required when installing or updating Ruby stdlib extension gems. ## Versioning diff --git a/common.js b/common.js index d457846..de15984 100644 --- a/common.js +++ b/common.js @@ -175,7 +175,6 @@ const GitHubHostedPlatforms = [ 'ubuntu-22.04-arm64', 'ubuntu-24.04-x64', 'ubuntu-24.04-arm64', - 'windows-2019-x64', 'windows-2022-x64', 'windows-2025-x64', 'windows-11-arm64' diff --git a/dist/index.js b/dist/index.js index 84b638b..d231f96 100644 --- a/dist/index.js +++ b/dist/index.js @@ -495,7 +495,6 @@ const GitHubHostedPlatforms = [ 'ubuntu-22.04-arm64', 'ubuntu-24.04-x64', 'ubuntu-24.04-arm64', - 'windows-2019-x64', 'windows-2022-x64', 'windows-2025-x64', 'windows-11-arm64'