Automatically pick the latest version of 2.6 for testing

* 2.6.7 is not yet available on Windows
Add Ruby 2.5.9, 2.6.7, 2.7.3 and 3.0.1
2026-09-13 14:34:21 +02:00 · 2021-04-05 19:47:58 +02:00 · 2021-04-05 19:39:06 +02:00 · 2021-04-02 11:47:35 +02:00 · 2021-04-02 11:47:35 +02:00 · 2021-04-02 11:47:35 +02:00
8 changed files with 34 additions and 23 deletions
@@ -10,10 +10,11 @@ assignees: ''
 <!--
 Before filing this issue:
 * If the issue happens on JRuby or TruffleRuby, and does not happen on CRuby (please check), file an issue there instead. It's very unlikely ruby/setup-ruby is the cause.
-* Try to reproduce the issue locally by following the workflow steps (including all all commands done by ruby/setup-ruby, except for `Downloading Ruby` & `Extracting Ruby`). If it does reproduce locally, it's not a ruby/setup-ruby issue.
+* Try to reproduce the issue locally by following the workflow steps (including all commands done by ruby/setup-ruby, except for `Downloading Ruby` & `Extracting Ruby`). If it does reproduce locally, it's not a ruby/setup-ruby issue.

 Please provide:
 * the code of or a link to the workflow used
 * the link to the log of a failed workflow job
 * the command and output of the step failing
+* whether you are using a self-hosted runner
 -->
@@ -16,8 +16,7 @@ jobs:
      fail-fast: false
      matrix:
        os: [ ubuntu-18.04, ubuntu-20.04, macos-10.15, macos-11.0, windows-2016, windows-2019 ]
-        # Use various version syntax here for testing
-        ruby: [ 2.1, 2.2, 2.3, 2.4, 2.5, 2.6.6, 2.7, '3.0', ruby-head, jruby, jruby-head, truffleruby, truffleruby-head ]
+        ruby: [ 2.1, 2.2, 2.3, 2.4, 2.5, 2.6, 2.7, '3.0', ruby-head, jruby, jruby-head, truffleruby, truffleruby-head ]
        include:
        - { os: windows-2016, ruby: mingw }
        - { os: windows-2019, ruby: mingw }
@@ -95,9 +94,10 @@ jobs:
    - name: bash test
      shell: bash
      run: echo ~
-    - name: Windows JRuby
-      if: startsWith(matrix.os, 'windows') && startsWith(matrix.ruby, 'jruby')
-      run: gem install sassc -N
+    # Disabled until https://github.com/jruby/jruby/issues/6648 is fixed
+    # - name: Windows JRuby
+    #   if: startsWith(matrix.os, 'windows') && startsWith(matrix.ruby, 'jruby')
+    #   run: gem install sassc -N

  testExactBundlerVersion:
    name: "Test with an exact Bundler version"
@@ -14,8 +14,8 @@ This action currently supports these versions of MRI, JRuby and TruffleRuby:

 | Interpreter | Versions |
 | ----------- | -------- |
-| `ruby` | 2.1.9, 2.2, 2.3.0 - 2.3.8, 2.4.0 - 2.4.10, 2.5.0 - 2.5.8, 2.6.0 - 2.6.6, 2.7.2, 3.0.0, head, debug, mingw, mswin |
-| `jruby` | 9.1.17.0, 9.2.9.0 - 9.2.15.0, head |
+| `ruby` | 2.1.9, 2.2, all versions from 2.3.0 until 3.0.1, head, debug, mingw, mswin |
+| `jruby` | 9.1.17.0, 9.2.9.0 - 9.2.17.0, head |
 | `truffleruby` | 19.3.0 - 21.0.0, head |

 `ruby-debug` is the same as `ruby-head` but with assertions enabled (`-DRUBY_DEBUG=1`).  
@@ -38,7 +38,7 @@ The action works for all [GitHub-hosted runners](https://help.github.com/en/acti

 | Operating System | Recommended | Other Supported Versions |
 | ----------- | -------- | -------- |
-| Ubuntu  | `ubuntu-latest`  (= `ubuntu-18.04`) | `ubuntu-20.04`, `ubuntu-16.04` |
+| Ubuntu  | `ubuntu-latest`  (= `ubuntu-20.04`) | `ubuntu-18.04`, `ubuntu-16.04` |
 | macOS   | `macos-latest`   (= `macos-10.15`)  | `macos-11.0` |
 | Windows | `windows-latest` (= `windows-2019`) | `windows-2016` |

@@ -83,6 +83,7 @@ jobs:
      fail-fast: false
      matrix:
        os: [ubuntu-latest, macos-latest]
+        # Due to https://github.com/actions/runner/issues/849, we have to use quotes for '3.0'
        ruby: [2.5, 2.6, 2.7, '3.0', head, jruby, jruby-head, truffleruby, truffleruby-head]
    runs-on: ${{ matrix.os }}
    steps:
@@ -110,7 +111,7 @@ jobs:
      BUNDLE_GEMFILE: gemfiles/${{ matrix.gemfile }}.gemfile
    steps:
      - uses: actions/checkout@v2
-      - uses: ./
+      - uses: ruby/setup-ruby@v1
        with:
          ruby-version: 2.6
          bundler-cache: true # runs 'bundle install' and caches installed gems automatically
@@ -215,7 +216,7 @@ This action might work with [self-hosted runners](https://docs.github.com/en/act
 if the [virtual environment](https://github.com/actions/virtual-environments) is very similar to the ones used by GitHub runners. Notably:

 * Make sure to use the same operating system and version.
-* Set the environment variable `ImageOS` to the corresponding value on GitHub-hosted runners (e.g. `ubuntu18`/`macos1015`/`win19`). This is necessary to detect the operating system and version.
+* Set the environment variable `ImageOS` on the runner to the corresponding value on GitHub-hosted runners (e.g. `ubuntu18`/`macos1015`/`win19`). This is necessary to detect the operating system and version.
 * Make sure to use the same version of libssl.
 * Make sure that the operating system has `libyaml-0` installed
 * The default tool cache directory (`/opt/hostedtoolcache` on Linux, `/Users/runner/hostedtoolcache` on macOS,
@@ -81,6 +81,8 @@ export async function installBundler(bundlerVersionInput, lockFile, platform, ru
  }

  if (common.isHeadVersion(rubyVersion) && common.isBundler2Default(engine, rubyVersion) && bundlerVersion.startsWith('2')) {
+    // Avoid installing a newer Bundler version for head versions as it might not work.
+    // For releases, even if they ship with Bundler 2 we install the latest Bundler.
    console.log(`Using Bundler 2 shipped with ${engine}-${rubyVersion}`)
  } else if (engine === 'truffleruby' && !common.isHeadVersion(rubyVersion) && bundlerVersion.startsWith('1')) {
    console.log(`Using Bundler 1 shipped with ${engine}`)
@@ -59,7 +59,9 @@ export function isBundler2Default(engine, rubyVersion) {
  if (engine === 'ruby') {
    return isHeadVersion(rubyVersion) || floatVersion(rubyVersion) >= 2.7
  } else if (engine === 'truffleruby') {
-    return isHeadVersion(rubyVersion)
+    return isHeadVersion(rubyVersion) || floatVersion(rubyVersion) >= 21.0
+  } else if (engine === 'jruby') {
+    return isHeadVersion(rubyVersion) || floatVersion(rubyVersion) >= 9.3
  } else {
    return false
  }
@@ -32851,7 +32851,9 @@ function isBundler2Default(engine, rubyVersion) {
  if (engine === 'ruby') {
    return isHeadVersion(rubyVersion) || floatVersion(rubyVersion) >= 2.7
  } else if (engine === 'truffleruby') {
-    return isHeadVersion(rubyVersion)
+    return isHeadVersion(rubyVersion) || floatVersion(rubyVersion) >= 21.0
+  } else if (engine === 'jruby') {
+    return isHeadVersion(rubyVersion) || floatVersion(rubyVersion) >= 9.3
  } else {
    return false
  }
@@ -44617,6 +44619,8 @@ async function installBundler(bundlerVersionInput, lockFile, platform, rubyPrefi
  }

  if (common.isHeadVersion(rubyVersion) && common.isBundler2Default(engine, rubyVersion) && bundlerVersion.startsWith('2')) {
+    // Avoid installing a newer Bundler version for head versions as it might not work.
+    // For releases, even if they ship with Bundler 2 we install the latest Bundler.
    console.log(`Using Bundler 2 shipped with ${engine}-${rubyVersion}`)
  } else if (engine === 'truffleruby' && !common.isHeadVersion(rubyVersion) && bundlerVersion.startsWith('1')) {
    console.log(`Using Bundler 1 shipped with ${engine}`)
@@ -45346,15 +45350,15 @@ function getVersions(platform) {
      "2.2.10",
      "2.3.0", "2.3.1", "2.3.2", "2.3.3", "2.3.4", "2.3.5", "2.3.6", "2.3.7", "2.3.8",
      "2.4.0", "2.4.1", "2.4.2", "2.4.3", "2.4.4", "2.4.5", "2.4.6", "2.4.7", "2.4.9", "2.4.10",
-      "2.5.0", "2.5.1", "2.5.2", "2.5.3", "2.5.4", "2.5.5", "2.5.6", "2.5.7", "2.5.8",
-      "2.6.0", "2.6.1", "2.6.2", "2.6.3", "2.6.4", "2.6.5", "2.6.6",
-      "2.7.0", "2.7.1", "2.7.2",
-      "3.0.0-preview1", "3.0.0-preview2", "3.0.0-rc1", "3.0.0",
+      "2.5.0", "2.5.1", "2.5.2", "2.5.3", "2.5.4", "2.5.5", "2.5.6", "2.5.7", "2.5.8", "2.5.9",
+      "2.6.0", "2.6.1", "2.6.2", "2.6.3", "2.6.4", "2.6.5", "2.6.6", "2.6.7",
+      "2.7.0", "2.7.1", "2.7.2", "2.7.3",
+      "3.0.0-preview1", "3.0.0-preview2", "3.0.0-rc1", "3.0.0", "3.0.1",
      "head", "debug",
    ],
    "jruby": [
      "9.1.17.0",
-      "9.2.9.0", "9.2.10.0", "9.2.11.0", "9.2.11.1", "9.2.12.0", "9.2.13.0", "9.2.14.0", "9.2.15.0",
+      "9.2.9.0", "9.2.10.0", "9.2.11.0", "9.2.11.1", "9.2.12.0", "9.2.13.0", "9.2.14.0", "9.2.15.0", "9.2.16.0", "9.2.17.0",
      "head"
    ],
    "truffleruby": [
@@ -1,4 +1,5 @@
 #!/usr/bin/sh
 set -e
+yarn install
 yarn run package
 exec git add dist/index.js
@@ -5,15 +5,15 @@ export function getVersions(platform) {
      "2.2.10",
      "2.3.0", "2.3.1", "2.3.2", "2.3.3", "2.3.4", "2.3.5", "2.3.6", "2.3.7", "2.3.8",
      "2.4.0", "2.4.1", "2.4.2", "2.4.3", "2.4.4", "2.4.5", "2.4.6", "2.4.7", "2.4.9", "2.4.10",
-      "2.5.0", "2.5.1", "2.5.2", "2.5.3", "2.5.4", "2.5.5", "2.5.6", "2.5.7", "2.5.8",
-      "2.6.0", "2.6.1", "2.6.2", "2.6.3", "2.6.4", "2.6.5", "2.6.6",
-      "2.7.0", "2.7.1", "2.7.2",
-      "3.0.0-preview1", "3.0.0-preview2", "3.0.0-rc1", "3.0.0",
+      "2.5.0", "2.5.1", "2.5.2", "2.5.3", "2.5.4", "2.5.5", "2.5.6", "2.5.7", "2.5.8", "2.5.9",
+      "2.6.0", "2.6.1", "2.6.2", "2.6.3", "2.6.4", "2.6.5", "2.6.6", "2.6.7",
+      "2.7.0", "2.7.1", "2.7.2", "2.7.3",
+      "3.0.0-preview1", "3.0.0-preview2", "3.0.0-rc1", "3.0.0", "3.0.1",
      "head", "debug",
    ],
    "jruby": [
      "9.1.17.0",
-      "9.2.9.0", "9.2.10.0", "9.2.11.0", "9.2.11.1", "9.2.12.0", "9.2.13.0", "9.2.14.0", "9.2.15.0",
+      "9.2.9.0", "9.2.10.0", "9.2.11.0", "9.2.11.1", "9.2.12.0", "9.2.13.0", "9.2.14.0", "9.2.15.0", "9.2.16.0", "9.2.17.0",
      "head"
    ],
    "truffleruby": [
Author	SHA1	Message	Date
Benoit Daloze	d320226fe2	Automatically pick the latest version of 2.6 for testing * 2.6.7 is not yet available on Windows	2021-04-05 19:47:58 +02:00
Benoit Daloze	d2f535c1ed	Add Ruby 2.5.9, 2.6.7, 2.7.3 and 3.0.1 * Simplify list of supported CRuby versions.	2021-04-05 19:39:06 +02:00
Benoit Daloze	ad65390c0a	Disable sassc test on JRuby on Windows as it fails on 9.2.17.0 * See https://github.com/jruby/jruby/issues/6648	2021-04-02 11:47:35 +02:00
Benoit Daloze	c5c7583a68	Run 'yarn install' in pre-commit hook to make sure the right ncc version is used	2021-04-02 11:47:35 +02:00
Charles Oliver Nutter	117edf3c27	Update for JRuby 9.2.17.0	2021-04-02 11:47:35 +02:00
Benoit Daloze	df8f44e55c	Improve issue template	2021-03-28 17:31:46 +02:00
Benoit Daloze	2b7bafee36	Clarify	2021-03-28 17:26:01 +02:00
Benoit Daloze	dddacd7ec1	Document the logic for whether to install Bundler	2021-03-25 16:49:40 +01:00
Benoit Daloze	5ee10197cf	TruffleRuby >= 21.0 and JRuby >= 9.3 ship with Bundler 2	2021-03-25 16:46:35 +01:00
Thomas E Enebo	4f47b3664d	JRuby 9.3 (head) and forward ships bundler (#164 )	2021-03-25 16:43:15 +01:00
Hiroyuki Shirakawa	b97fdb9941	write actual action name	2021-03-23 11:22:26 +01:00
Kazuhiro NISHIYAMA	0a19fc237d	ubuntu-latest is ubuntu-20.04 now https://github.com/actions/virtual-environments/blob/dee50eebffa60a7dd9149033675d44a027dd6b33/README.md#available-environments	2021-03-23 11:16:07 +01:00
Benoit Daloze	745f03fc1c	Simplify and shorten comment	2021-03-05 13:42:15 +01:00
OKURA Masafumi	51b5bc2e0e	Add a comment about version quotations to README As described in the comment, due to a bug discussed on https://github.com/actions/runner/issues/849, we currently have to use quotes for '3.0' as a workaround. This change makes it easy for people not to remove quotes as they misunderstand it's a typo.	2021-03-05 13:41:42 +01:00
Benoit Daloze	034294ac91	Add JRuby 9.2.16.0	2021-03-04 22:13:53 +01:00